Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend to PYTHONPATH in tests #2673

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Prepend to PYTHONPATH in tests #2673

merged 2 commits into from
Nov 11, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 11, 2024 •
edited
Loading

🦟 Bug fix

Fixes failing python tests

Summary

Preserve the existing PYTHONPATH by prepending instead of replacing. This is needed since we started using a virtual environment in CI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Prepend to PYTHONPATH in tests
0e29348 
Preserve the existing PYTHONPATH by prepending
instead of replacing.

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Nov 11, 2024
@scpeters scpeters mentioned this pull request Nov 11, 2024
Merged
@scpeters
Copy link
Member Author

I think both e527979 and gazebo-tooling/release-tools#1203 are needed to fix the python system loader integration test

@scpeters scpeters marked this pull request as ready for review November 11, 2024 18:56
@scpeters scpeters requested a review from mjcarroll as a code owner November 11, 2024 18:56
@scpeters
Copy link
Member Author

I think both e527979 and gazebo-tooling/release-tools#1203 are needed to fix the python system loader integration test

I'm going to temporarily reconfigure the homebrew jenkins job to use the release-tools branch from gazebo-tooling/release-tools#1203

@scpeters
Copy link
Member Author

@osrf-jenkins run tests please

@scpeters
Copy link
Member Author

I think both e527979 and gazebo-tooling/release-tools#1203 are needed to fix the python system loader integration test

I'm going to temporarily reconfigure the homebrew jenkins job to use the release-tools branch from gazebo-tooling/release-tools#1203

Build Status https://build.osrfoundation.org/job/gz_sim-ci-pr_any-homebrew-amd64/1074/

@scpeters scpeters merged commit 0d346de into gz-sim9 Nov 11, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/preserve_pythonpath branch November 11, 2024 21:53
@scpeters scpeters mentioned this pull request Nov 18, 2024
Merged
8 tasks
@scpeters
Copy link
Member Author

https://github.com/Mergifyio backport gz-sim8

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024 •
edited
Loading

backport gz-sim8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 18, 2024
@scpeters @mergify
Prepend to PYTHONPATH in tests (#2673)
c5bef54 
Preserve the existing PYTHONPATH by prepending
instead of replacing.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 0d346de)
@mergify mergify bot mentioned this pull request Nov 18, 2024
Merged
8 tasks
arjo129 pushed a commit that referenced this pull request Nov 19, 2024
@mergify @scpeters
Prepend to PYTHONPATH in tests (#2673) (#2681)
1bbb645 
Preserve the existing PYTHONPATH by prepending
instead of replacing.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 0d346de)

Co-authored-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @azeey